szaszm commented on a change in pull request #744: MINIFICPP-1171 - Fix "%ll"
format strings in log lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/744#discussion_r387623137
##########
File path: libminifi/src/RemoteProcessorGroupPort.cpp
##########
@@ -360,7 +360,7 @@ std::pair<std::string, int>
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo
return std::make_pair(host, siteTosite_port_);
}
} else {
- logger_->log_error("Cannot output body to content for
ProcessGroup::refreshRemoteSite2SiteInfo: received HTTP code %ll from %s",
client->getResponseCode(), fullUrl.str());
+ logger_->log_error("Cannot output body to content for
ProcessGroup::refreshRemoteSite2SiteInfo: received HTTP code %lld from %s",
client->getResponseCode(), fullUrl.str());
Review comment:
Use `PRId64` from `<cinttypes>` for `int64_t`. `lld` is meant to be used for
`long long int`, which is not guaranteed to be the same as `int64_t`. It is not
the same on my platform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
