arpadboda commented on a change in pull request #743: Minificpp 1169 - Simplify
C2 metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r391740598
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -173,9 +173,9 @@ void FlowController::initializePaths(const std::string
&adjustedFilename) {
FlowController::~FlowController() {
stop(true);
+ c2_agent_->stop();
Review comment:
Are you sure we can avoid the nullcheck here?
I don't think we have C2 agent in case c2 is not configured in the
minifi.properties file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
