szaszm commented on a change in pull request #743: Minificpp 1169 - Simplify C2 
metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r392280430
 
 

 ##########
 File path: libminifi/src/c2/C2Agent.cpp
 ##########
 @@ -66,8 +76,6 @@ C2Agent::C2Agent(const 
std::shared_ptr<core::controller::ControllerServiceProvid
 
   c2_producer_ = [&]() {
     auto now = std::chrono::steady_clock::now();
 
 Review comment:
   `now` can also be removed by changing from `request_mutex.try_lock_until(now 
+ duration)` to `request_mutex.try_lock_for(duration)` on line 80.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to