szaszm commented on a change in pull request #743: Minificpp 1169 - Simplify C2
metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r392204665
##########
File path: extensions/http-curl/tests/C2VerifyHeartbeatAndStop.cpp
##########
@@ -195,12 +130,23 @@ int main(int argc, char **argv) {
if (url.find("https") != std::string::npos) {
isSecure = true;
}
+ {
+ VerifyC2Heartbeat harness(isSecure);
+
+ harness.setKeyDir(key_dir);
+
+ HeartbeatHandler responder(isSecure);
+
+ harness.setUrl(url, &responder);
+
+ harness.run(test_file_location);
+ }
Review comment:
I think these statements logically fit together, so I see no reason for
separating them with empty lines.
The google style guide (which we reference in our CONTRIB.md) is even more
conservative than I am:
https://google.github.io/styleguide/cppguide.html#Vertical_Whitespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
