arpadboda commented on a change in pull request #748: MINIFICPP-1187
Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/748#discussion_r401494448
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -149,6 +149,14 @@ core::Property
ConsumeWindowsEventLog::BookmarkRootDirectory(
withDescription("Directory which contains processor state data.")->
build());
+core::Property ConsumeWindowsEventLog::ProcessOldEvents(
+ core::PropertyBuilder::createProperty("Process Old Events")->
+ isRequired(true)->
+ withAllowableValues<std::string>({ "true", "false" })->
Review comment:
In case you add a bool validator, you don't need this, but it becomes more
consistent with C2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
