am-c-p-p commented on a change in pull request #748: MINIFICPP-1187 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/748#discussion_r401740932
##########
File path: extensions/windows-event-log/Bookmark.cpp
##########
@@ -11,7 +11,7 @@ namespace nifi {
namespace minifi {
namespace processors {
-Bookmark::Bookmark(const std::wstring& channel, const std::wstring& query,
const std::string& bookmarkRootDir, const std::string& uuid,
std::shared_ptr<logging::Logger> logger)
+Bookmark::Bookmark(const std::wstring& channel, const std::wstring& query,
const std::string& bookmarkRootDir, const std::string& uuid, bool
processOldEvents, std::shared_ptr<logging::Logger> logger)
Review comment:
The change in Bookmark is internal to CWEL, it doesn't affect other code, it
is not necessary to maintain API signature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
