am-c-p-p commented on a change in pull request #748: MINIFICPP-1187 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/748#discussion_r401701273
##########
File path: extensions/windows-event-log/Bookmark.cpp
##########
@@ -48,7 +48,7 @@ Bookmark::Bookmark(const std::wstring& channel, const
std::wstring& query, const
}
const utils::ScopeGuard guard_hEventResults([hEventResults]() {
EvtClose(hEventResults); });
- if (!EvtSeek(hEventResults, 0, 0, 0, EvtSeekRelativeToLast)) {
+ if (!EvtSeek(hEventResults, 0, 0, 0, processOldEvents?
EvtSeekRelativeToFirst : EvtSeekRelativeToLast)) {
Review comment:
Since already processed events are bookmarked, only events which are not
processed from bookmark point will be processed, it could be not yet processed
old events or new ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
