tpalfy commented on a change in pull request #4223:
URL: https://github.com/apache/nifi/pull/4223#discussion_r413766080
##########
File path:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
##########
@@ -463,6 +463,8 @@ private static void writeValue(final SolrInputDocument
inputDocument, final Obje
addFieldToSolrDocument(inputDocument,fieldName,(BigInteger)coercedValue,fieldsToIndex);
}
break;
+ case BIGDECIMAL:
+ addFieldToSolrDocument(inputDocument, fieldName, coercedValue,
fieldsToIndex);
Review comment:
I'd use `DataTypeUtils.toBigDecimal(coercedValue, fieldName)` to be safe
and follow conventions.
Also, curse of the switch statement: `break;` seems to be missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
