turcsanyip commented on a change in pull request #4223:
URL: https://github.com/apache/nifi/pull/4223#discussion_r414816704



##########
File path: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##########
@@ -354,6 +358,7 @@ private static RecordFieldType getFieldType(final int 
sqlType, final String valu
             case Types.DATE:
                 return RecordFieldType.DATE;
             case Types.DECIMAL:
+                return RecordFieldType.BIGDECIMAL;
             case Types.DOUBLE:
             case Types.NUMERIC:

Review comment:
       The `NUMERIC` SQL type is a fixed-point decimal too.
   I think it should be handled together with `DECIMAL` and return BigDecimal 
here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to