simonbence commented on a change in pull request #4223:
URL: https://github.com/apache/nifi/pull/4223#discussion_r420179686



##########
File path: 
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##########
@@ -1759,6 +1812,8 @@ public static int getSQLTypeValue(final DataType 
dataType) {
                 return Types.DOUBLE;
             case FLOAT:
                 return Types.FLOAT;
+            case BIGDECIMAL:
+                return Types.NUMERIC;

Review comment:
       The best I found in the matter is 
[this](https://stackoverflow.com/questions/759401/is-there-any-difference-between-decimal-and-numeric-in-sql-server).
 I made my decision based on this as NUMERIC has less implementational freedom 
for different databases




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to