arpadboda commented on a change in pull request #786:
URL: https://github.com/apache/nifi-minifi-cpp/pull/786#discussion_r425865244
##########
File path: extensions/http-curl/tests/HTTPHandlers.h
##########
@@ -206,25 +207,36 @@ class FlowFileResponder : public CivetHandler {
minifi::io::CivetStream civet_stream(conn);
minifi::io::CRCStream < minifi::io::CivetStream > stream(&civet_stream);
uint32_t num_attributes;
+ int read;
uint64_t total_size = 0;
- total_size += stream.read(num_attributes);
+ read = stream.read(num_attributes);
+ if(!isServerRunning())return false;
Review comment:
Why?
I would expect not even trying to read the stream when the server is not
running.
Edit: okay, I get it, we check at every stream access.
Wonder if stream reads in this case might cause segfaults as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
