szaszm commented on a change in pull request #786:
URL: https://github.com/apache/nifi-minifi-cpp/pull/786#discussion_r425895222
##########
File path: extensions/http-curl/client/HTTPStream.h
##########
@@ -155,13 +155,13 @@ class HttpStream : public io::BaseStream {
protected:
/**
- * Creates a vector and returns the vector using the provided
- * type name.
+ * Populates the vector using the provided type name.
+ * @param buf output buffer
* @param t incoming object
- * @returns vector.
+ * @returns number of bytes read.
*/
template<typename T>
- std::vector<uint8_t> readBuffer(const T&);
+ int readBuffer(std::vector<uint8_t>&, const T&);
Review comment:
Correct, it's an inline non-virtual member function that happens to be
defined in many stream classes the same way. A lot of code duplication, but
works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
