adamdebreceni commented on a change in pull request #786:
URL: https://github.com/apache/nifi-minifi-cpp/pull/786#discussion_r427085519
##########
File path: libminifi/include/io/CRCStream.h
##########
@@ -145,17 +145,15 @@ class CRCStream : public BaseStream {
protected:
/**
- * Creates a vector and returns the vector using the provided
- * type name.
+ * Populates the vector using the provided type name.
+ * @param buf output buffer
* @param t incoming object
- * @returns vector.
+ * @returns number of bytes read.
*/
template<typename K>
- std::vector<uint8_t> readBuffer(const K& t) {
- std::vector<uint8_t> buf;
+ int readBuffer(std::vector<uint8_t>& buf, const K& t) {
Review comment:
readded the previous versions to libminifi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
