szaszm commented on a change in pull request #786:
URL: https://github.com/apache/nifi-minifi-cpp/pull/786#discussion_r427205135
##########
File path: extensions/civetweb/processors/ListenHTTP.h
##########
@@ -201,6 +201,8 @@ class ListenHTTP : public core::Processor {
}
return 0;
}
+ protected:
+ void notifyStop() override;
Review comment:
(Correctly) adding `override` to this virtual function triggered clang's
`-Winconsistent-missing-override` warnings for all other member functions that
override virtual functions. Could you add `override` to at least `onTrigger`,
`initialize` and `onSchedule` as well (but preferably to all such functions in
the file)?
https://travis-ci.org/github/apache/nifi-minifi-cpp/jobs/688702969#L12034
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override
https://google.github.io/styleguide/cppguide.html#Inheritance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
