szaszm commented on a change in pull request #770:
URL: https://github.com/apache/nifi-minifi-cpp/pull/770#discussion_r428167985
##########
File path: libminifi/src/io/StreamFactory.cpp
##########
@@ -16,12 +16,13 @@
* limitations under the License.
*/
#include "io/StreamFactory.h"
+
#include <atomic>
#include <memory>
#include <mutex>
#include <string>
-#include <utils/GeneralUtils.h>
+#include <utils/GeneralUtils.h> // NOLINT
Review comment:
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
I think if we replaced the angle brackets with quotation marks, the warning
would go away. Could you try this? If it doesn't work, them I'm fine with
leaving the NOLINT comments of such cases in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
