szaszm commented on a change in pull request #770:
URL: https://github.com/apache/nifi-minifi-cpp/pull/770#discussion_r428173660
##########
File path: libminifi/src/utils/OsUtils.cpp
##########
@@ -24,16 +24,18 @@
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
-#include <Windows.h>
#include <sddl.h>
+#include <Windows.h>
Review comment:
Judging from the appveyor output, the order of these includes matter.
Not sure of the exact reason, but in general windows headers are a mess, so I'm
not surprised. :(
See the end of the log here:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/nifi-minifi-cpp/builds/33004452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
