szaszm commented on a change in pull request #770: URL: https://github.com/apache/nifi-minifi-cpp/pull/770#discussion_r428174378
########## File path: libminifi/test/tensorflow-tests/TensorFlowTests.cpp ########## @@ -19,14 +19,14 @@ #include <memory> #include <string> -#include <tensorflow/cc/framework/scope.h> -#include <tensorflow/cc/ops/standard_ops.h> -#include <processors/PutFile.h> -#include <processors/GetFile.h> -#include <processors/LogAttribute.h> +#include <processors/GetFile.h> // NOLINT +#include <processors/LogAttribute.h> // NOLINT +#include <processors/PutFile.h> // NOLINT +#include <tensorflow/cc/framework/scope.h> // NOLINT +#include <tensorflow/cc/ops/standard_ops.h> // NOLINT Review comment: Regarding my previous suggestion: I suggest trying to convert our headers to use quotation marks and leave 3rd parties as is, even if it means that we need to use NOLINT. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org