arpadboda commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r444227780
##########
File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp
##########
@@ -58,16 +57,11 @@ class VerifyC2DescribeCoreComponentState : public
VerifyC2Describe {
class DescribeCoreComponentStateHandler: public HeartbeatHandler {
public:
-
- explicit DescribeCoreComponentStateHandler(bool isSecure)
- : HeartbeatHandler(isSecure) {
- }
-
- virtual void handleHeartbeat(const rapidjson::Document&, struct
mg_connection * conn) {
+ virtual void handleHeartbeat(const rapidjson::Document&, struct
mg_connection * conn) override {
Review comment:
As it was historically not used around the project, that would hurt.
Although if you place at least one in a class, you will get compiler
warnings for the missing ones. (compiler forces consistency)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
