[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #820: MINIFICPP-1183 - Cleanup C2 Update tests

[GitBox]

hunyadi-dev commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r445414945



##########
File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp
##########
@@ -58,16 +57,11 @@ class VerifyC2DescribeCoreComponentState : public 
VerifyC2Describe {
 
 class DescribeCoreComponentStateHandler: public HeartbeatHandler {
  public:
-
-  explicit DescribeCoreComponentStateHandler(bool isSecure)
-      : HeartbeatHandler(isSecure) {
-  }
-
-  virtual void handleHeartbeat(const rapidjson::Document&, struct 
mg_connection * conn) {
+  virtual void handleHeartbeat(const rapidjson::Document&, struct 
mg_connection * conn) override {

Review comment:
       It is checked and reported by the linter. This file is probably not in 
the list of targets.
   <img width="911" alt="Screenshot 2020-06-25 at 11 05 20" 
src="https://user-images.githubusercontent.com/64011968/85690333-c3f21b80-b6d3-11ea-8977-544fd386b6b0.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org