adamdebreceni commented on a change in pull request #820:
URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r451404038
##########
File path: extensions/http-curl/tests/HTTPHandlers.h
##########
@@ -360,23 +359,19 @@ class DeleteTransactionResponder : public
ServerAwareHandler {
std::string response_code;
};
-class HeartbeatHandler : public ServerAwareHandler {
- public:
- explicit HeartbeatHandler(bool isSecure)
- : isSecure(isSecure) {
- }
-
- std::string readPost(struct mg_connection *conn) {
- std::string response;
- int readBytes;
+std::string readPayload(struct mg_connection *conn) {
+ std::string response;
+ int readBytes;
- char buffer[1024];
- while ((readBytes = mg_read(conn, buffer, sizeof(buffer))) > 0) {
- response.append(buffer, (readBytes / sizeof(char)));
- }
- return response;
+ char buffer[1024];
+ while ((readBytes = mg_read(conn, buffer, sizeof(buffer))) > 0) {
+ response.append(buffer, (readBytes / sizeof(char)));
Review comment:
I know it's old code but that division by `sizeof(char)` though 😏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
