[
https://issues.apache.org/jira/browse/OPENNLP-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214980#comment-16214980
]
ASF GitHub Bot commented on OPENNLP-1150:
-----------------------------------------
jzonthemtn commented on a change in pull request #281: OPENNLP-1150:
TokenNameFinderTrainerTool should use ModelUtil.createD…
URL: https://github.com/apache/opennlp/pull/281#discussion_r146236922
##########
File path:
opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/TokenNameFinderTrainerTool.java
##########
@@ -115,7 +114,7 @@ public void run(String format, String[] args) {
mlParams = CmdLineUtil.loadTrainingParameters(params.getParams(), true);
if (mlParams == null) {
- mlParams = new TrainingParameters();
Review comment:
Should the public constructor for `TrainingParameters` be made private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TokenNameFinderTrainerTool should use
> ModelUtil.createDefaultTrainingParameters() when mlParams is null
> -------------------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1150
> URL: https://issues.apache.org/jira/browse/OPENNLP-1150
> Project: OpenNLP
> Issue Type: Improvement
> Components: Name Finder
> Affects Versions: 1.8.2
> Reporter: Koji Sekiguchi
> Priority: Trivial
> Fix For: 1.8.3
>
>
> Unlike other TrainerTools, TokenNameFinderTrainerTool create an empty
> TrainingParameters when mlParams is null by calling the constructor.
> TokenNameFinderTrainerTool should use
> ModelUtil.createDefaultTrainingParameters() like as other TrainerTools do to
> initialize mlParams.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
