[
https://issues.apache.org/jira/browse/OPENNLP-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215208#comment-16215208
]
ASF GitHub Bot commented on OPENNLP-1150:
-----------------------------------------
danielruss commented on issue #281: OPENNLP-1150: TokenNameFinderTrainerTool
should use ModelUtil.createD…
URL: https://github.com/apache/opennlp/pull/281#issuecomment-338675903
No, please don’t make the constructor private. opennlp-tools is used as a
library also. If you make the TrainingParameters constructor private, you can
ONLY create training parameters via a file. Also a defaultTrainingParameters
method uses this constructor.
From: Jeff Zemerick <[email protected]>
Reply-To: apache/opennlp <[email protected]>
Date: Monday, October 23, 2017 at 7:32 AM
To: apache/opennlp <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [apache/opennlp] OPENNLP-1150: TokenNameFinderTrainerTool
should use ModelUtil.createD… (#281)
@jzonthemtn commented on this pull request.
________________________________
In
opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/TokenNameFinderTrainerTool.java<https://github.com/apache/opennlp/pull/281#discussion_r146236922>:
> @@ -115,7 +114,7 @@ public void run(String format, String[] args) {
mlParams = CmdLineUtil.loadTrainingParameters(params.getParams(), true);
if (mlParams == null) {
- mlParams = new TrainingParameters();
Should the public constructor for TrainingParameters be made private?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/opennlp/pull/281#pullrequestreview-71148301>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/ADl9e7QyZInReTI2dTWY6Z-wdMA1jmFuks5svHk0gaJpZM4QCh66>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TokenNameFinderTrainerTool should use
> ModelUtil.createDefaultTrainingParameters() when mlParams is null
> -------------------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1150
> URL: https://issues.apache.org/jira/browse/OPENNLP-1150
> Project: OpenNLP
> Issue Type: Improvement
> Components: Name Finder
> Affects Versions: 1.8.2
> Reporter: Koji Sekiguchi
> Priority: Trivial
> Fix For: 1.8.3
>
>
> Unlike other TrainerTools, TokenNameFinderTrainerTool create an empty
> TrainingParameters when mlParams is null by calling the constructor.
> TokenNameFinderTrainerTool should use
> ModelUtil.createDefaultTrainingParameters() like as other TrainerTools do to
> initialize mlParams.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
