[
https://issues.apache.org/jira/browse/OPENNLP-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216440#comment-16216440
]
ASF GitHub Bot commented on OPENNLP-1150:
-----------------------------------------
kojisekig commented on issue #281: OPENNLP-1150: TokenNameFinderTrainerTool
should use ModelUtil.createD…
URL: https://github.com/apache/opennlp/pull/281#issuecomment-338898352
Thanks everyone for reviewing this!
As @jzonthemtn commented, when I created this patch, I thought we could add
the notice in the javadoc of TrainingParameters constructor so that users can
know the existence of ModelUtil.createDefaultTrainingParameters(), but I
noticed that the javadoc of ModelUtil.createDefaultTrainingParameters() says
> Note: Do not use this method, internal use only!
So I didn't touch them. :)
Can someone explain the background on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> TokenNameFinderTrainerTool should use
> ModelUtil.createDefaultTrainingParameters() when mlParams is null
> -------------------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1150
> URL: https://issues.apache.org/jira/browse/OPENNLP-1150
> Project: OpenNLP
> Issue Type: Improvement
> Components: Name Finder
> Affects Versions: 1.8.2
> Reporter: Koji Sekiguchi
> Priority: Trivial
> Fix For: 1.8.3
>
>
> Unlike other TrainerTools, TokenNameFinderTrainerTool create an empty
> TrainingParameters when mlParams is null by calling the constructor.
> TokenNameFinderTrainerTool should use
> ModelUtil.createDefaultTrainingParameters() like as other TrainerTools do to
> initialize mlParams.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
