[ 
https://issues.apache.org/jira/browse/OPENNLP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775268#comment-17775268
 ] 

ASF GitHub Bot commented on OPENNLP-1384:
-----------------------------------------

epugh commented on code in PR #553:
URL: https://github.com/apache/opennlp/pull/553#discussion_r1359475741


##########
opennlp-dl/src/test/java/opennlp/dl/doccat/DocumentCategorizerDLEval.java:
##########
@@ -92,6 +92,46 @@ public void categorize() throws IOException, OrtException {
 
   }
 
+  @Test
+  public void categorizeWithAutomaticLabels() throws IOException, OrtException 
{
+
+    final File model = new File(getOpennlpDataDir(),

Review Comment:
   Does OpenNLP package these, or do you download them to run the tests?  A 
question taht will come up in Solr-land is "Wait, for the test you want a 600 
mb .onnx file???"...  ;-).  How do you handle the models for testing?





> Automatically generate document classifications map from model's config.json
> ----------------------------------------------------------------------------
>
>                 Key: OPENNLP-1384
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1384
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Deep Learning
>    Affects Versions: 2.0.0
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>            Priority: Major
>
> Automatically generate classifications map from model's config.json.
> Currently, the implementations utilizing ONNX Runtime require a Map that 
> stores the model-assigned value along with the human readable name for each 
> value. This map must be created manually:
> Map<Integer, String> classifications = new HashMap<>();
> classifications.put(0, "negative");
> classifications.put(1, "positive");
> How to create this map is determined by looking at the model's config.json 
> file. This task is to have OpenNLP read the config.json file and make the map 
> automatically instead of requiring the user to make it manually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to