[
https://issues.apache.org/jira/browse/OPENNLP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775287#comment-17775287
]
ASF GitHub Bot commented on OPENNLP-1384:
-----------------------------------------
rzo1 commented on code in PR #553:
URL: https://github.com/apache/opennlp/pull/553#discussion_r1359532468
##########
opennlp-dl/pom.xml:
##########
@@ -42,6 +42,11 @@
<artifactId>onnxruntime_gpu</artifactId>
<version>${onnxruntime.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
Review Comment:
We could use https://github.com/netplex/json-smart-v2 for parsing the json
input - it is also ASLv2. It is just 120KB instead of 2MB from Jackson (+
Jackson Core).
> Automatically generate document classifications map from model's config.json
> ----------------------------------------------------------------------------
>
> Key: OPENNLP-1384
> URL: https://issues.apache.org/jira/browse/OPENNLP-1384
> Project: OpenNLP
> Issue Type: Task
> Components: Deep Learning
> Affects Versions: 2.0.0
> Reporter: Jeff Zemerick
> Assignee: Jeff Zemerick
> Priority: Major
>
> Automatically generate classifications map from model's config.json.
> Currently, the implementations utilizing ONNX Runtime require a Map that
> stores the model-assigned value along with the human readable name for each
> value. This map must be created manually:
> Map<Integer, String> classifications = new HashMap<>();
> classifications.put(0, "negative");
> classifications.put(1, "positive");
> How to create this map is determined by looking at the model's config.json
> file. This task is to have OpenNLP read the config.json file and make the map
> automatically instead of requiring the user to make it manually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
