[
https://issues.apache.org/jira/browse/OPENNLP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778335#comment-17778335
]
ASF GitHub Bot commented on OPENNLP-1384:
-----------------------------------------
kinow commented on code in PR #553:
URL: https://github.com/apache/opennlp/pull/553#discussion_r1367876033
##########
NOTICE:
##########
@@ -93,3 +93,9 @@ NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+============================================================================
+
+jackson-databind
+https://github.com/FasterXML/jackson-databind
+The Apache Software License, Version 2.0
Review Comment:
Missing newline at end
##########
opennlp-dl/src/main/java/opennlp/dl/doccat/DocumentCategorizerConfig.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.dl.doccat;
+
+import java.util.Map;
+
+public class DocumentCategorizerConfig {
+
+ private Map<String, String> id2label;
+
+ public Map<String, String> getId2label() {
+ return id2label;
Review Comment:
it appears to be loaded and then read only, without modifying the map. Maybe
this could return a read-only map? To avoid somewhere else we accidentally
modify it unintentionally (when that happens we can review and check if we need
to worry about threads...)
> Automatically generate document classifications map from model's config.json
> ----------------------------------------------------------------------------
>
> Key: OPENNLP-1384
> URL: https://issues.apache.org/jira/browse/OPENNLP-1384
> Project: OpenNLP
> Issue Type: Task
> Components: Deep Learning
> Affects Versions: 2.0.0
> Reporter: Jeff Zemerick
> Assignee: Jeff Zemerick
> Priority: Major
>
> Automatically generate classifications map from model's config.json.
> Currently, the implementations utilizing ONNX Runtime require a Map that
> stores the model-assigned value along with the human readable name for each
> value. This map must be created manually:
> Map<Integer, String> classifications = new HashMap<>();
> classifications.put(0, "negative");
> classifications.put(1, "positive");
> How to create this map is determined by looking at the model's config.json
> file. This task is to have OpenNLP read the config.json file and make the map
> automatically instead of requiring the user to make it manually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
