bdoyle0182 commented on a change in pull request #5169:
URL: https://github.com/apache/openwhisk/pull/5169#discussion_r781454185
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationStore.scala
##########
@@ -35,21 +35,25 @@ case class UserContext(user: Identity, request: HttpRequest
= HttpRequest())
trait ActivationStore {
protected val disableStoreResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreResult)
+ protected val disableStoreNonBlockingResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreNonBlockingResult)
protected val unstoredLogsEnabledConfig =
loadConfigOrThrow[Boolean](ConfigKeys.unstoredLogsEnabled)
/**
* Checks if an activation should be stored in database and stores it.
*
* @param activation activation to store
* @param isBlockingActivation is activation blocking
+ * @param disableBlockingStore do not store activation if successful and
blocking
+ * @param disableNonBlockingStore do not store activation if successful and
non-blocking
Review comment:
Yea so what I was originally going to say as well is that I think we're
just getting close to having a separate config for each invocation type,
blocking and non-blocking. In your list, the original person that created the
blocking config wanted only blocking failures and all non-blocking; which is
why I had `STORE_NON_BLOCKING_OR_ON_BLOCKING_FAILURE`. Almost everyone would
want this because not storing any non-blocking means you can't run sequences I
believe. But you are correct that would mean the parameters aren't orthogonal,
which is why I think we're at the point of just having two separate params with
the same enum.
`STORE_ALWAYS`
`STORE_FAILURES`
`STORE_FAILURES_NOT_APPLICATION_ERRORS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
