rabbah commented on a change in pull request #5169:
URL: https://github.com/apache/openwhisk/pull/5169#discussion_r780791709
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationStore.scala
##########
@@ -35,21 +35,25 @@ case class UserContext(user: Identity, request: HttpRequest
= HttpRequest())
trait ActivationStore {
protected val disableStoreResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreResult)
+ protected val disableStoreNonBlockingResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreNonBlockingResult)
protected val unstoredLogsEnabledConfig =
loadConfigOrThrow[Boolean](ConfigKeys.unstoredLogsEnabled)
/**
* Checks if an activation should be stored in database and stores it.
*
* @param activation activation to store
* @param isBlockingActivation is activation blocking
+ * @param disableBlockingStore do not store activation if successful and
blocking
+ * @param disableNonBlockingStore do not store activation if successful and
non-blocking
Review comment:
`STORE_NON_BLOCKING_OR_ON_BLOCKING_FAILURE` and `STORE_ON_FAILURE` are
redundant for blocking invokes, no? That is, to store all non blocking I'd use
`STORE_NON_BLOCKING_OR_ON_BLOCKING_FAILURE` and to only store non blocking
failures, I'd use `STORE_ON_FAILURE` and to store blocking failures, i can use
either. (I think the parameters should be orthogonal.)
I like the addition of `STORE_ON_NON_APPLICATION_FAILURE` - It further
refines the on failure mode - so this would capture system errors and uncaught
exceptions in the end user code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
