bdoyle0182 commented on a change in pull request #5169:
URL: https://github.com/apache/openwhisk/pull/5169#discussion_r759706120
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationStore.scala
##########
@@ -35,21 +35,25 @@ case class UserContext(user: Identity, request: HttpRequest
= HttpRequest())
trait ActivationStore {
protected val disableStoreResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreResult)
+ protected val disableStoreNonBlockingResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreNonBlockingResult)
protected val unstoredLogsEnabledConfig =
loadConfigOrThrow[Boolean](ConfigKeys.unstoredLogsEnabled)
/**
* Checks if an activation should be stored in database and stores it.
*
* @param activation activation to store
* @param isBlockingActivation is activation blocking
+ * @param disableBlockingStore do not store activation if successful and
blocking
+ * @param disableNonBlockingStore do not store activation if successful and
non-blocking
Review comment:
I agree with that setup. The one case that I think is confusing is the
existing boolean and wanting failed blocking activations to still be stored.
Because setting the current boolean means store failed blocking activations and
non-blocking activations. So that falls between `STORE_ON_FAILURE` and
`STORE_NON_BLOCKING`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
