rabbah commented on a change in pull request #5169:
URL: https://github.com/apache/openwhisk/pull/5169#discussion_r788216445
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationStore.scala
##########
@@ -33,32 +32,43 @@ import scala.concurrent.Future
case class UserContext(user: Identity, request: HttpRequest = HttpRequest())
trait ActivationStore {
-
+ /* DEPRECATED: disableStoreResult config is now deprecated replaced with
blocking activation store level */
Review comment:
```suggestion
/* DEPRECATED: disableStoreResult config is now deprecated replaced with
blocking activation store level (storeBlockingResultLevel) */
```
##########
File path: common/scala/src/main/resources/application.conf
##########
@@ -438,10 +438,19 @@ whisk {
# uniqueName + displayName 253 (max pod name length in
Kube)
serdes-overhead = 6068 // 3034 bytes of metadata * 2 for extra headroom
+ # DEPRECATED, use store-blocking-result-level
# Disables database store for blocking + successful activations
# invocations made with `X-OW-EXTRA-LOGGING: on` header, will force
the activation to be stored
disable-store-result = false
+ # Result level to store in db for blocking activations (STORE_ALWAYS,
STORE_FAILURES, STORE_FAILURES_NOT_APPLICATION_ERRORS)
+ # invocations made with `X-OW-EXTRA-LOGGING: on` header, will force
the activation to be stored
+ store-blocking-result-level = "STORE_ALWAYS"
+
+ # Result level to store in db for blocking activations (STORE_ALWAYS,
STORE_FAILURES, STORE_FAILURES_NOT_APPLICATION_ERRORS)
Review comment:
```suggestion
# Result level to store in db for non-blocking activations
(STORE_ALWAYS, STORE_FAILURES, STORE_FAILURES_NOT_APPLICATION_ERRORS)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
