bdoyle0182 commented on a change in pull request #5169:
URL: https://github.com/apache/openwhisk/pull/5169#discussion_r796290756
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationStore.scala
##########
@@ -33,32 +32,52 @@ import scala.concurrent.Future
case class UserContext(user: Identity, request: HttpRequest = HttpRequest())
trait ActivationStore {
+ val logging: Logging
+ /* DEPRECATED: disableStoreResult config is now deprecated replaced with
blocking activation store level (storeBlockingResultLevel) */
protected val disableStoreResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreResult)
+ protected val storeBlockingResultLevelConfig = {
+ try {
+
ActivationStoreLevel.valueOf(loadConfigOrThrow[String](ConfigKeys.storeBlockingResultLevel))
+ } catch {
+ case _: Exception =>
+ val disableStoreResultConfig =
loadConfigOrThrow[Boolean](ConfigKeys.disableStoreResult)
+ logging.warn(
+ this,
+ s"The config ${ConfigKeys.disableStoreResult} being used is
deprecated. Please use the replacement config
${ConfigKeys.storeBlockingResultLevel}")
+ if (disableStoreResultConfig) ActivationStoreLevel.STORE_FAILURES else
ActivationStoreLevel.STORE_ALWAYS
+ }
+ }
+ protected val storeNonBlockingResultLevelConfig =
Review comment:
We can discuss a date to remove it since we're not really following
consistent releases and I'll send an email announcing the plan to remove it.
I don't think it needs to be moved since the existing behavior is to fail if
it doesn't exist which maybe was unnecessary originally and we don't need to
keep it long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
