ningyougang commented on code in PR #5229:
URL: https://github.com/apache/openwhisk/pull/5229#discussion_r867649969
##########
tests/src/test/scala/org/apache/openwhisk/core/controller/test/ActionsApiTests.scala:
##########
@@ -546,6 +545,342 @@ class ActionsApiTests extends ControllerTestCommon with
WhiskActionsApi {
}
}
+ it should "reject create when memory is greater than maximum allowed
namespace limit" in {
+ implicit val tid = transid()
+
+ val allowed = ByteSize(128, SizeUnits.MB)
+ val is = ByteSize(512, SizeUnits.MB)
+
+ val credsWithNamespaceLimits = WhiskAuthHelpers
+ .newIdentity()
+ .copy(limits = UserLimits(actionMemoryMax = Some(MemoryLimit(allowed))))
+
+ val content = WhiskActionPut(
+ Some(jsDefault("_")),
+ Some(Parameters("x", "X")),
+ Some(
+ ActionLimitsOption(
+ Some(TimeLimit(TimeLimit.MAX_DURATION)),
+ Some(MemoryLimit(is)),
+ Some(LogLimit(LogLimit.MAX_LOGSIZE)),
+ Some(ConcurrencyLimit(ConcurrencyLimit.MAX_CONCURRENT)))))
+
+ Put(s"$collectionPath/${aname()}", content) ~>
Route.seal(routes(credsWithNamespaceLimits)) ~> check {
+ status should be(BadRequest)
+ responseAs[String] should include {
+ Messages.sizeExceedsAllowedThreshold(MemoryLimit.memoryLimitFieldName,
is.toMB.toInt, allowed.toMB.toInt)
+ }
+ }
+ }
Review Comment:
I am ok with test case, can provide the opposite test case? e.g. allow
create when memory is greater than maximum allowed namespace limit
##########
tests/src/test/scala/org/apache/openwhisk/core/controller/test/ActionsApiTests.scala:
##########
@@ -546,6 +545,342 @@ class ActionsApiTests extends ControllerTestCommon with
WhiskActionsApi {
}
}
+ it should "reject create when memory is greater than maximum allowed
namespace limit" in {
+ implicit val tid = transid()
+
+ val allowed = ByteSize(128, SizeUnits.MB)
+ val is = ByteSize(512, SizeUnits.MB)
+
+ val credsWithNamespaceLimits = WhiskAuthHelpers
+ .newIdentity()
+ .copy(limits = UserLimits(actionMemoryMax = Some(MemoryLimit(allowed))))
+
+ val content = WhiskActionPut(
+ Some(jsDefault("_")),
+ Some(Parameters("x", "X")),
+ Some(
+ ActionLimitsOption(
+ Some(TimeLimit(TimeLimit.MAX_DURATION)),
+ Some(MemoryLimit(is)),
+ Some(LogLimit(LogLimit.MAX_LOGSIZE)),
+ Some(ConcurrencyLimit(ConcurrencyLimit.MAX_CONCURRENT)))))
+
+ Put(s"$collectionPath/${aname()}", content) ~>
Route.seal(routes(credsWithNamespaceLimits)) ~> check {
+ status should be(BadRequest)
+ responseAs[String] should include {
+ Messages.sizeExceedsAllowedThreshold(MemoryLimit.memoryLimitFieldName,
is.toMB.toInt, allowed.toMB.toInt)
+ }
+ }
+ }
Review Comment:
I am ok with test case, can provide the opposite test case? e.g. allow
create when memory is greater than maximum allowed namespace limit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
