bdoyle0182 commented on code in PR #5229:
URL: https://github.com/apache/openwhisk/pull/5229#discussion_r868840103
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala:
##########
@@ -624,6 +626,30 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
})
}
+ private def checkNamespaceAndSystemLimits(user: Identity, content:
WhiskActionPut)(
Review Comment:
Should this be two separate functions? The context in which you check the
set limits for a namespace are different from the context you check the system
limits. You check against the system limits when creating the action or
updating your namespace's configuration. When you check against the namespace's
limit it would be on the execution path when an activation is occurring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
