ningyougang commented on code in PR #5222:
URL: https://github.com/apache/openwhisk/pull/5222#discussion_r868983272
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerClient.scala:
##########
@@ -204,7 +205,12 @@ class DockerClient(dockerHost: Option[String] = None,
s"running ${cmd.mkString(" ")} (timeout: $timeout)",
logLevel = InfoLevel)
executeProcess(cmd, timeout).andThen {
- case Success(_) => transid.finished(this, start)
+ case Success(_) =>
+ MetricEmitter.emitHistogramMetric(
+ LogMarkerToken("docker", "runCmd", "duration", Some(args.head),
Map("cmd" -> args.head))(
+ MeasurementUnit.time.milliseconds),
+ Instant.now.toEpochMilli - transid.meta.start.toEpochMilli)
Review Comment:
Already changed to use `transid.finish` to send the metric and delete the
repeated one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
