ningyougang commented on code in PR #5222:
URL: https://github.com/apache/openwhisk/pull/5222#discussion_r868992430
##########
common/scala/src/main/scala/org/apache/openwhisk/common/Logging.scala:
##########
@@ -493,12 +502,10 @@ object LoggingMarkers {
val INVOKER_ACTIVATION = LogMarkerToken(invoker, activation,
start)(MeasurementUnit.none)
def INVOKER_DOCKER_CMD(cmd: String) =
LogMarkerToken(invoker, "docker", start, Some(cmd), Map("cmd" ->
cmd))(MeasurementUnit.time.milliseconds)
- def INVOKER_DOCKER_CMD_TIMEOUT(cmd: String) =
- LogMarkerToken(invoker, "docker", timeout, Some(cmd), Map("cmd" ->
cmd))(MeasurementUnit.none)
def INVOKER_RUNC_CMD(cmd: String) =
LogMarkerToken(invoker, "runc", start, Some(cmd), Map("cmd" ->
cmd))(MeasurementUnit.time.milliseconds)
def INVOKER_KUBEAPI_CMD(cmd: String) =
- LogMarkerToken(invoker, "kubeapi", start, Some(cmd), Map("cmd" ->
cmd))(MeasurementUnit.none)
+ LogMarkerToken(invoker, "kubeapi", start, Some(cmd), Map("cmd" ->
cmd))(MeasurementUnit.time.milliseconds)
Review Comment:
Obviously, the unit should be `MeasurementUnit.time.milliseconds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
