upgle commented on code in PR #5229:
URL: https://github.com/apache/openwhisk/pull/5229#discussion_r928475692
##########
tests/src/test/scala/org/apache/openwhisk/core/entity/test/SchemaTests.scala:
##########
@@ -826,61 +825,16 @@ class SchemaTests extends FlatSpec with BeforeAndAfter
with ExecHelpers with Mat
serdes foreach { s =>
withClue(s"serializer $s") {
- if (s != LogLimit.serdes) {
- val lb = the[DeserializationException] thrownBy s.read(JsNumber(0))
- lb.getMessage should include("below allowed threshold")
- } else {
+ if (s == LogLimit.serdes) {
val lb = the[DeserializationException] thrownBy s.read(JsNumber(-1))
lb.getMessage should include("a negative size of an object is not
allowed")
}
-
- val ub = the[DeserializationException] thrownBy
s.read(JsNumber(Int.MaxValue))
- ub.getMessage should include("exceeds allowed threshold")
-
val int = the[DeserializationException] thrownBy s.read(JsNumber(2.5))
int.getMessage should include("limit must be whole number")
}
}
}
- it should "reject bad limit values" in {
Review Comment:
The scheme test based on the hardcoded limit value is no longer used and
validation checks are performed based on user input at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
