upgle commented on PR #5229:
URL: https://github.com/apache/openwhisk/pull/5229#issuecomment-1204905199
@bdoyle0182 Thanks for your comments.
> i.e. if the system memory limit default is 256mb, can you change the
default value for a specific namespace to 128mb?
If the system memory limit is 256mb, and default memory limit is 128mb, you
can create action with 128mb memory, higher memory is not available. If
administrator gives you a higher memory limit (called namespace limit), you can
create an action with 256mb memory.
This namespace limit can be set in a document with the key
`{namespace}/limits` by system administrator.
And the default limit of a namespace is a value set as an environment
variable during deployment. If not set, the same value is set as the current
system limit for backward compatibility.
----
I also feel it's not easy to explain different types of concurrency. The
name "action concurrency" is already used a lot in code, and configs. I used
the same name because using a different name from the existing one is rather
confusing.
```scala
behavior of "Action concurrency limits"
```
```scala
val actionConcurrency = 5
```
```scala
* @param concurrency the action concurrency limit to be set in test
* @param ec the expected exit code when creating the action
val concurrencyEnabled =
Option(WhiskProperties.getProperty("whisk.action.concurrency")).exists(_.toBoolean)
```
And the difference is that the "maxActionConcurrency" config added in this
PR are not exposed to the user.
Because the name is similar to the existing "concurrency" config, users may
need to read the document to understand the concept of new container
concurrency.
- maxActionConcurrency
- The config is not exposed to the user. (It's admin setting)
- maxContainerConcurrency
- The config is exposed to the user by action limit.
```scala
concurrency: ConcurrencyLimit = ConcurrencyLimit(),
maxContainerConcurrency: Option[ContainerConcurrencyLimit] = None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
