style95 commented on PR #5229: URL: https://github.com/apache/openwhisk/pull/5229#issuecomment-1204637710
It's worth discussing. I feel there are mainly two big concurrencies. 1. Concurrent containers. (concurrent in-flight activations in the old scheduler) 2. Concurrent activations in one container. Currently, we call 1. as `concurrentInvocations` and for 2., just `concurrency`. I feel we need to clean up these names first. Since the name, `concurrentInvocations` best fits with `ShardingContainerPoolBalancer` and it is still being used, it might not be easy to change the name before we drop supporting it. So we can think about `concurrency`. The `concurrency` is only referring to the intra-concurrency in one container until now. Since it is related to the action container, I feel `maxActionConcurrency` is sort of aligned with it. But for `maxContainerConcurrency`, I am unsure if this best describes what we intended. `Container` may not best fit in case OW is running on K8S as it is using Pod. I feel it should not include a certain implementation in the name. We might introduce containerless runtime in the future. This configuration is basically to allow overprovision of containers beyond the default `concurrentInvocations`. We may consider names like the below until we keep using `concurrentInvocations` for container-level concurrency. * `maxConcurrentInvocations`. * Some names related to `overprovision`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
