style95 commented on code in PR #5304:
URL: https://github.com/apache/openwhisk/pull/5304#discussion_r936174802
##########
tests/src/test/scala/org/apache/openwhisk/core/scheduler/queue/test/MemoryQueueFlowTests.scala:
##########
@@ -151,11 +164,11 @@ class MemoryQueueFlowTests
container.send(fsm, getActivation(false))
container.expectMsg(ActivationResponse(Left(NoActivationMessage())))
- Thread.sleep(idleGrace.toMillis)
+ fsm ! StateTimeout
Review Comment:
Yes but I feel the semantic is different.
For example, if anyone removes the `stateTimeout` configuration in each
state in MemoryQueue by mistake, the previous code can guarantee that it should
be added.
But the changed code cannot guarantee it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
