upgle commented on code in PR #5304:
URL: https://github.com/apache/openwhisk/pull/5304#discussion_r936223845
##########
tests/src/test/scala/org/apache/openwhisk/core/scheduler/queue/test/MemoryQueueFlowTests.scala:
##########
@@ -151,11 +164,11 @@ class MemoryQueueFlowTests
container.send(fsm, getActivation(false))
container.expectMsg(ActivationResponse(Left(NoActivationMessage())))
- Thread.sleep(idleGrace.toMillis)
+ fsm ! StateTimeout
Review Comment:
@style95 I think what you said can be guaranteed with separate test code
waiting for timeout.
For example, with a very short time timeout setting, the test code can wait
as much as the actual timeout. I'll add some test code that covers what you
said. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
