style95 commented on code in PR #5304:
URL: https://github.com/apache/openwhisk/pull/5304#discussion_r937517308
##########
tests/src/test/scala/org/apache/openwhisk/core/scheduler/queue/test/MemoryQueueFlowTests.scala:
##########
@@ -151,11 +164,11 @@ class MemoryQueueFlowTests
container.send(fsm, getActivation(false))
container.expectMsg(ActivationResponse(Left(NoActivationMessage())))
- Thread.sleep(idleGrace.toMillis)
+ fsm ! StateTimeout
Review Comment:
I meant what you added here:
https://github.com/apache/openwhisk/commit/c1de659e9428df36b1f1febe1a2832bd90fc16c4#diff-042a5fb7a94e1f4755cd38f9d3892ceed3db93e54cb7d34bd9bdf8289ef7c7fcR185
covers the timeout for the normal flow.
But there are many cases for other timeouts such as `flushGrace` and
`gracefulShutdownTimeout`.
The MemoryQueueFlowTests guarantees the behavior of the memory queue in
order, so I just want to make sure its coverage is not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
