bdoyle0182 commented on code in PR #5326:
URL: https://github.com/apache/openwhisk/pull/5326#discussion_r976699995
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -732,7 +735,12 @@ class FunctionPullingContainerProxy(
data.action.fullyQualifiedName(false),
data.action.rev,
Some(data.clientProxy))
-
+ case Event(t: FailureMessage, data: WarmData) =>
+ logging.error(
+ this,
+ s"Failed to determine whether to keep or remove container on pause
timeout for ${data.container.containerId}, retrying. Caused by: $t")
+ startSingleTimer(DetermineKeepContainer.toString,
DetermineKeepContainer, 1.second)
Review Comment:
Hmm I think that shouldn't be the case. If a request comes in for the
container, it will receive the `Initialize` message to unpause the container
and go back to running. The retry message for `DetermineKeepContainer` after
one second is cancelled at the beginning of the `Initialize` event along with
the other timers so it should just gracefully unpause and go back to running so
the latency is the duration of a normal unpause operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
