style95 commented on code in PR #5326:
URL: https://github.com/apache/openwhisk/pull/5326#discussion_r977263889
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -732,7 +735,12 @@ class FunctionPullingContainerProxy(
data.action.fullyQualifiedName(false),
data.action.rev,
Some(data.clientProxy))
-
+ case Event(t: FailureMessage, data: WarmData) =>
+ logging.error(
+ this,
+ s"Failed to determine whether to keep or remove container on pause
timeout for ${data.container.containerId}, retrying. Caused by: $t")
+ startSingleTimer(DetermineKeepContainer.toString,
DetermineKeepContainer, 1.second)
Review Comment:
Then how about introducing a maximum retry value?
After retrying x times to get the container count, if it fails, we can
remove the container.
I feel it would be meaningless to keep the problematic containers for the
keepingWarm count if the issue persists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
