bdoyle0182 commented on code in PR #5326:
URL: https://github.com/apache/openwhisk/pull/5326#discussion_r977249445
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -732,7 +735,12 @@ class FunctionPullingContainerProxy(
data.action.fullyQualifiedName(false),
data.action.rev,
Some(data.clientProxy))
-
+ case Event(t: FailureMessage, data: WarmData) =>
+ logging.error(
+ this,
+ s"Failed to determine whether to keep or remove container on pause
timeout for ${data.container.containerId}, retrying. Caused by: $t")
+ startSingleTimer(DetermineKeepContainer.toString,
DetermineKeepContainer, 1.second)
Review Comment:
yes that's correct that's the current behavior I've set up. I guess in
theory you could remove the container if the request fails, but you'd then
break the guarantee of the keepingWarm count for the namespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
