style95 commented on code in PR #5284:
URL: https://github.com/apache/openwhisk/pull/5284#discussion_r1005252691
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/SchedulingDecisionMaker.scala:
##########
@@ -79,7 +89,7 @@ class SchedulingDecisionMaker(
*
* However, if the container exists(totalContainers != 0), the
activation is not treated as a failure and the activation is delivered to the
container.
*/
- case Running =>
+ case Running if totalContainers == 0 ||
!schedulingConfig.allowOverProvisionBeforeThrottle =>
Review Comment:
I feel there is a subtle difference in the semantics when the feature is
enabled.
Let's say there are one action utilizing 30 containers, and 15 actions with
1 container each.
The `totalContainers` is always bigger than 0. Then isn't throttling enabled?
The throttling would be enabled when an activation for another action
arrives, and no container is created.
I think it would be better to enable the namespace throttling when the
number of containers reaches `namespace limit * overprovisoinRatio`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
