bdoyle0182 commented on code in PR #5284:
URL: https://github.com/apache/openwhisk/pull/5284#discussion_r1005946253
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/SchedulingDecisionMaker.scala:
##########
@@ -79,7 +89,7 @@ class SchedulingDecisionMaker(
*
* However, if the container exists(totalContainers != 0), the
activation is not treated as a failure and the activation is delivered to the
container.
*/
- case Running =>
+ case Running if totalContainers == 0 ||
!schedulingConfig.allowOverProvisionBeforeThrottle =>
Review Comment:
the reasoning for this is so that activations can continue processing when
the 15th action gets the last 1 container. If the 15th action can handle the
throughput at this point it wouldn't want namespace throttling enabled so it
can continue processing activations. You wouldn't want to stop activation
processing until the 16th action comes in.
Or am I misremembering and namespace throttling only impacts new actions
with 0 containers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
