bdoyle0182 commented on code in PR #5284:
URL: https://github.com/apache/openwhisk/pull/5284#discussion_r1007536497
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/SchedulingDecisionMaker.scala:
##########
@@ -79,7 +89,7 @@ class SchedulingDecisionMaker(
*
* However, if the container exists(totalContainers != 0), the
activation is not treated as a failure and the activation is delivered to the
container.
*/
- case Running =>
+ case Running if totalContainers == 0 ||
!schedulingConfig.allowOverProvisionBeforeThrottle =>
Review Comment:
I believe I have updated this behavior and added a commit to what you
requested in the latest commit.
I think this pr should be good to go except for one remaining issue I just
thought of if one of the 15 actions that got the overprovisioning slots and
namespace throttling is enabled and one of those actions containers are removed
then I'm not sure if namespace throttling will be correctly disabled, I just
need to verify that before merging tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
