tysonnorris commented on a change in pull request #2414: SPI approach for
pluggable implementations
URL:
https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r124658262
##########
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##########
@@ -86,18 +86,18 @@ protected[core] trait WhiskDocument
}
}
-protected[core] object Util {
- def makeStore[D <: DocumentSerializer](config: WhiskConfig, name:
WhiskConfig => String)(
- implicit jsonFormat: RootJsonFormat[D],
- actorSystem: ActorSystem,
- logging: Logging): ArtifactStore[D] = {
- require(config != null && config.isValid, "config is undefined or not
valid")
- require(config.dbProvider == "Cloudant" || config.dbProvider ==
"CouchDB", "Unsupported db.provider: " + config.dbProvider)
- assume(Set(config.dbProtocol, config.dbHost, config.dbPort,
config.dbUsername, config.dbPassword, name(config)).forall(_.nonEmpty), "At
least one expected property is missing")
-
- new CouchDbRestStore[D](config.dbProtocol, config.dbHost,
config.dbPort.toInt, config.dbUsername, config.dbPassword, name(config))
- }
-}
+//protected[core] object Util {
Review comment:
done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
