tysonnorris commented on a change in pull request #2414: SPI approach for
pluggable implementations
URL:
https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r124658213
##########
File path:
tests/src/test/scala/whisk/core/cli/test/SequenceMigrationTests.scala
##########
@@ -55,6 +54,9 @@ class SequenceMigrationTests
val wsk = new Wsk
val whiskConfig = new WhiskConfig(WhiskEntityStore.requiredProperties)
// handle on the entity datastore
+
+ SharedModules.initSharedModules(List(new SharedModule(actorSystem,
whiskConfig, logging)))
Review comment:
actually I think this is no longer required - previously it was
instantiating all Spi instances on load of first instance, now it only
instantiates impl on access of first instance of that Spi type; removed these
calls for now, but if they are needed, I now have a way to add them as you
describe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
