rabbah commented on a change in pull request #2218: Port Controller from Spray
to Akka
URL:
https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127030713
##########
File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala
##########
@@ -173,16 +174,21 @@ trait WhiskTriggersApi extends WhiskCollectionAPI {
Path.SingleSlash +
rule.action.name.asString
}
}.toString
-
val actionUrl = Path("/api/v1") /
"namespaces" / actionNamespace / "actions"
+ val request = HttpRequest(
+ method = POST,
+ uri = url.withPath(actionUrl +
actionPath),
+ headers =
List(Authorization(BasicHttpCredentials(user.authkey.uuid.toString,
user.authkey.key.toString))),
+ entity =
HttpEntity(MediaTypes.`application/json`, args.get.compactPrint)
Review comment:
Two lines up toString should be asString (in other places to - all our types
have asString converters; toString used for printing primarily).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
